Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in AdaptiveGraphRouting.RenderElements #924

Merged

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Dec 1, 2022

BACKGROUND:

  • After recent changes to AdaptiveGraphRouting RenderElements function stopped assigning colors to ModelLine objects.

DESCRIPTION:

  • Fix wrong assignment of EdgeFlag flags.
  • Removed coloring main/non main layer since main layer is obsolete.
  • Instead color user/offset hint lines and and divide regular edges into groups with weights < 1, near 1 and > 1.

TESTING:

  • All test are passing.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Removed coloring main/non main layer since main layer is obsolete. Instead color user/offset hint lines and and divide regular edges into groups with weights < 1, near 1 and > 1.
Weight information is included into ModelLines.
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit dc11441 into hypar-io:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants