Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EdgeInfo.Flags hotfix #926

Merged
merged 5 commits into from
Dec 2, 2022
Merged

EdgeInfo.Flags hotfix #926

merged 5 commits into from
Dec 2, 2022

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Dec 2, 2022 •
edited by andrewheumann

BACKGROUND:

  • During testing of AdaptiveGraphRouting I have found that HasVerticalChanes flag is set incorrecly.

DESCRIPTION:

  • Made EdgeInfo.Flags private.
  • Fix wrong usage of bit flag in EdgeInfo constructor.

TESTING:

  • Failed case is included into EdgeInfoFlagsTest.

REQUIRED:

  • All changes are up to date in CHANGELOG.md. (No changes required)

This change is Reviewable

wynged
wynged approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit a640e33 into hypar-io:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DmytroMuravskyi @wynged