Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Message.FromCurve that can take any Curve including Line, Polyline, etc. #932

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Dec 23, 2022

BACKGROUND:

  • I needed a way to visualize a warning related to a polyline but there was only a way to do it for a single line. After inspecting the code I realized that one function can handle both line and polyline

DESCRIPTION:

  • Added Message.FromCurve: much simpler function that takes both line and polyline.
  • Message.FromLine is set obsolete.

TESTING:

  • No test were added as Message class is about representation and not covered by unit tests.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

…ine, etc.

`Message.FromLine` is set obsolete.
@wynged wynged self-requested a review December 29, 2022 15:55
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 91550ea into hypar-io:master Dec 29, 2022
@DmytroMuravskyi DmytroMuravskyi deleted the message-from-curve branch December 29, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants