In AdaptiveGridRouting, if there are several connection points with…

[DmytroMuravskyi]

… the same cost - choose one that is closer to the trunk.

BACKGROUND:

• While testing routing pattern that consist of several parallel lines with many inputs each, it was discovered that routing can choose any paths between lines since they produce the same tree sum. This was not consistent since numeric noise decided which one is shortest.

DESCRIPTION:

• If there are several connection points with the same cost - choose one that is closer to the trunk.

TESTING:

• Added new AdaptiveGraphRoutingEqualTransitions test that covers this case.

FUTURE WORK:

REQUIRED:

• All changes are up to date in CHANGELOG.md.

COMMENTS:

• AdaptiveGraphRoutingEqualTransitions uses more compact way where Vector3 name is often skipped.

---

This change is 

[wynged]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @DmytroMuravskyi)

---

Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 370 at r1 (raw file):

                    bool betterCost = order == TreeOrder.FurthestToClosest ?
                        localBestCost > bestCost : localBestCost < bestCost;
                    if (sameCost || betterCost)

can we logically seperate the sameCost behavior here from the better cost checking? Like do just the if same cost block, and inside compute the localCostToTrunk, and then if we get out of that compute the better cost?

---

Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 403 at r1 (raw file):

            {
                var leafNode = leafsToTrunkTree[leaf];
                if(leafNode.Leafs.Any())

comment for what this check is doing?

[DmytroMuravskyi]

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @wynged)

---

Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 370 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

can we logically seperate the sameCost behavior here from the better cost checking? Like do just the if same cost block, and inside compute the localCostToTrunk, and then if we get out of that compute the better cost?

Both cases lead to the exactly same code and both need localCostToTrunk to store it for the future. The only difference is that we need to skip if sameCost && localCostToTrunk >= bestCostToTrunk
I think code is well structured: minimum repeating code and localCostToTrunk is not calculated if not needed.

---

Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 403 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

comment for what this check is doing?

Done.

[wynged]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained

---

Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 370 at r1 (raw file):

Previously, DmytroMuravskyi wrote…

Both cases lead to the exactly same code and both need localCostToTrunk to store it for the future. The only difference is that we need to skip if sameCost && localCostToTrunk >= bestCostToTrunk
I think code is well structured: minimum repeating code and localCostToTrunk is not calculated if not needed.

ok, works for me!