Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve zero angle handling in Polyline.ForceAngleCompliance #943

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Improve zero angle handling in Polyline.ForceAngleCompliance #943

merged 1 commit into from
Feb 13, 2023

Conversation

nadiia-volyk
Copy link
Contributor

@nadiia-volyk nadiia-volyk commented Feb 13, 2023 •
edited by andrewheumann

BACKGROUND:

  • The ForceAngleCompliance method didn't work with 0 angle because in AngleAlignedDistance zero value was used in denominator

DESCRIPTION:

  • Add special handling for zero angle

TESTING:

  • Added PolylineForceAngleComplianceWithZeroAngle test to PolylineTests

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

@wynged wynged self-requested a review February 13, 2023 20:10
wynged
wynged approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit fd21c3f into hypar-io:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nadiia-volyk @wynged