Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wall intersections where bounded areas are not being created #970

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented Apr 17, 2023

BACKGROUND:
The wall intersections were not created inside some visibly bound areas:

image

image

It happens on some E-shaped intersections:
image

The problem occurs when building a tree. The order of vertexes looks like this:
image

And the tree traversal with LeftMostPointComparer:
image
On step 2 the line on the right site is not added, because it's not the leftMost point. On step 3 the bottom line is removed as successor to upper line. So point 4 is never added to the tree:
image

The solution is two change events order and change the LeftMost point location for lines || to Y axis:
image

DESCRIPTION:

  • This PR contains changes above and tests with different E-shaped networks

TESTING:

  • A added tests

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Copy link
Contributor

@ikeough ikeough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@katehryhorenko katehryhorenko merged commit c9d7e0b into master Apr 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants