-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalized #972
Normalized #972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ikeough)
Elements/src/Geometry/BoundedCurve.cs
line 127 at r1 (raw file):
/// positive Z axis points along the curve. /// </summary> /// <param name="u">The transform at a parameter along the curve between 0.0 and 1.0.</param>
I think the argument is not a transform ,it just is the parameter. similar to above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @ikeough)
Elements/test/ArcTests.cs
line 322 at r2 (raw file):
// The start, end, and mid points are the same, but we also want to ensure // that the curve didn't flip directions as well. We do this by testing // another random parameter.
if start and end are correct how could it have become flipped?
A polyline where the start and the end are the same would have matching end points, but could still be wound in the opposite direction. |
BACKGROUND:
During discussion of of the impact of the changes to curve parameterization in 2.0, @wynged said that it would ease the transition for existing code that uses
PointAt
, if we could have replacement methods likePointAtNormalized
.DESCRIPTION:
PointAtNormalized
andTransformAtNormalized
.This change is