Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete entities from Message, EdgeInfo, AdaptiveGrid and AdaptiveGraphRouting #974

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Apr 21, 2023

BACKGROUND:

  • Since Elements is now in 2.0 alpha stage, it's good opportunity to remove obsolete items, I introduced.

DESCRIPTION:

  • Message: removed obsolete FromLine method.
  • AdaptiveGrid: removed obsolete TryGetVertexIndex with tolerance parameter.
  • EdgeInfo: obsolete attribute is removed from HasVerticalChange property.
  • RoutingConfiguration: removed obsolete MainLayer and LayerPenalty properties.

TESTING:

  • No impact on Elements tests.

FUTURE WORK:

  • Removed methods and properties must be removed from downstream repos in order to use Elements 2.0

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@wynged wynged self-requested a review April 21, 2023 13:02
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 6d2bee8 into hypar-io:master Apr 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants