Emissive #979
Merged
Emissive #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Emissive in the glTF spec is RGB. We currently flatten this into one value. I might also take this opportunity to make it RGB, so we can support colors of emitted light that aren't the material color. |
katehryhorenko
approved these changes
May 15, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
While debugging materials for Hypar's Unreal integration, we noticed that emissive factor was only being applied if the emissive texture was used as well. You should be able to use one without the other.
DESCRIPTION:
This PR applies the emissive factor whether there is an emissive texture or not, and it sets the emissive factor to 0 by default, as opposed to 1.0. An emissive factor of 1 would cause all materials to appear to emit light.
REQUIRED:
CHANGELOG.md.Materials with increasing emissive factors.
This change is