Do not break loop if one of the tess objects is empty #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katehryhorenko
changed the title
wynged
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
I don' think so, I got feedback that some low level fixes like this don't warrant entry in the change log.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
wynged
requested changes
Jun 22, 2023
There was a problem hiding this comment.
oh actually, should we add that file as a test? might be nice
Reviewable status: 1 change requests, 0 of 1 approvals obtained
katehryhorenko
commented
Jul 7, 2023
There was a problem hiding this comment.
Done
Reviewable status: 1 change requests, 0 of 1 approvals obtained
wynged
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
One of the walls from Revit doesn't appear in viewer
DESCRIPTION:
Solid cannot be tessellated when it's an extrusion created from profile where not all points are on the same plane. Even when they are on the same plane but the offset is really small:
This offset can produce tess objects without elements.
By replacing "return" with "continue" we are allowing to tesselate this type of extrusions
TESTING:
I published this change to the JSON to Model function (TEST). I tried it on Basic Revit model where I mostly saw this issue.
REQUIRED:
Do I need to add this change to the backlog?
CHANGELOG.md.This change is