handle tolerance gaps for WallsLOD200 #100
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 1 unresolved discussion (waiting on @jamesbradleym)
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 138 at r1 (raw file):
} } catch (Exception e)
we actually don't want to do this try/catch because then a hy-ccup won't be trigggered, and that is way that problems become visible to us.
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 1 unresolved discussion (waiting on @wynged)
LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 138 at r1 (raw file):
Previously, wynged (Eric Wassail) wrote…
we actually don't want to do this try/catch because then a hy-ccup won't be trigggered, and that is way that problems become visible to us.
Ah, gotcha - try/catch removed
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained, all discussions resolved
We were allowing walls within a certain distance threshold to be merged if they were collinear, however this made the mergedcollinear method upset because those walls were too far. This PR projects those wall lines that are too far.
Tested against multiple workflows that that threw a WallsLOD200 Hy-ccups:
https://hypar.io/workflows/4c4eb24a-37d6-49e2-bc48-a291462d274f?api=staging
https://hypar.io/workflows/56fd3882-549f-4690-8846-8c8351eb7fa0?api=staging
https://hypar.io/workflows/7304eda5-1718-4c35-a103-52c2ee35263e?api=staging
This change is