Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #47

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

KaterynaSloboda
Copy link
Contributor

@KaterynaSloboda KaterynaSloboda commented Jul 3, 2023

  • Added tests to layout functions

This change is Reviewable

Copy link
Contributor

@serenayl serenayl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 115 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 2 unresolved discussions (waiting on @KaterynaSloboda)


LayoutFunctions/ClassroomLayout/test/ClassroomLayoutTests.cs line 47 at r3 (raw file):

            }

            // room with 3 desks

I think this is a room with 9 desks, unless I am reading this code wrong?

Code quote:

// room with 3 desks

LayoutFunctions/LoungeLayout/test/LoungeLayoutTests.cs line 43 at r3 (raw file):

                var boundaryElements = elements.Where(e => offsetedBox.Contains(e.Transform.Origin)).ToList();
                
                foreach (var contentItem in config.ContentItems)

For future people, maybe it is helpful to add comments inside of the tests like, "check that every piece of expected content exists in a room of a matching size"? This is a general comment for the tests in general, a plaintext explanation of what we are looking for.

Code quote:

foreach (var contentItem in config.ContentItems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants