Walls lod200

[jamesbradleym]

BACKGROUND:

• We want to handle wall merge and deduplication in Pringle so we have cleaner geometry to work with as well as export to Revit

DESCRIPTION:

• Implements a de-dup and merge function called Walls LOD 200

---

This change is 

[wynged]

Reviewed 17 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained, 2 unresolved discussions (waiting on @jamesbradleym)

---

LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 139 at r2 (raw file):

        }

        private class LineEqualityComparer : IEqualityComparer<Line>

lets put this in a separate file.

---

LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 144 at r2 (raw file):

            {
                // Check if start and end points of lines are equal
                return (x.Start == y.Start && x.End == y.End) || (x.Start == y.End && x.End == y.Start);

let's use pnt1.IsAlmostEqualTo(pnt2) here to at least give some floating point numeric tolerance.

[wynged]

Reviewable status: 1 change requests, 0 of 1 approvals obtained, 3 unresolved discussions (waiting on @jamesbradleym)

---

LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 117 at r2 (raw file):

                            Line otherLine = mergedLines[j];

                            if (line.IsCollinear(otherLine) && (line.TryGetOverlap(otherLine, out var overlap) || line.DistanceTo(otherLine) < 0.0001))

redundant collinearity check?

[jamesbradleym]

Reviewable status: 1 change requests, 0 of 1 approvals obtained, 3 unresolved discussions (waiting on @wynged)

---

LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 117 at r2 (raw file):

Previously, wynged (Eric Wassail) wrote…

redundant collinearity check?

Done.

---

LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 139 at r2 (raw file):

Previously, wynged (Eric Wassail) wrote…

lets put this in a separate file.

Done.

---

LayoutFunctions/WallsLOD200/src/WallsLOD200.cs line 144 at r2 (raw file):

Previously, wynged (Eric Wassail) wrote…

let's use pnt1.IsAlmostEqualTo(pnt2) here to at least give some floating point numeric tolerance.

Done.

[wynged]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained, all discussions resolved