Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounded Z values #99

Merged
merged 1 commit into from
May 15, 2024
Merged

rounded Z values #99

merged 1 commit into from
May 15, 2024

Conversation

wynged
Copy link
Member

@wynged wynged commented May 13, 2024

got some hy-ccup alerts regarding walls LOD200
we should do rounding to make sure our walls function doesn't error.
We should also see if we can make the pringle not make bad geometry, but this might still be a good idea.

this workflow shows the error, you can toggle test on/off for walls LOD 200 to see the fix
https://hypar.io/workflows/57e786c9-9c8e-446b-a337-6b27aa858506?api=staging


This change is Reviewable

@wynged wynged requested a review from jamesbradleym May 13, 2024 20:44
Copy link
Contributor

@jamesbradleym jamesbradleym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained, all discussions resolved

@wynged wynged merged commit 07b118c into master May 15, 2024
1 check passed
@wynged wynged deleted the tolerant-walls branch May 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants