Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements; add server.CloseConnection method #39

Merged
merged 6 commits into from
Mar 18, 2021
Merged

Test improvements; add server.CloseConnection method #39

merged 6 commits into from
Mar 18, 2021

Commits on Mar 9, 2020

  1. add server.CloseConnection to support forcibly closing a connection

    @daveyarwood
    daveyarwood committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    8c61eed View commit details
    Browse the repository at this point in the history

  2. improve error handling in message dispatch/receive tests 

    * Handle errors from client.Send.

* Use the higher-level server.ListenAndServe, which makes a connection
internally.

* Handle the non-problematic case where we get an expected error because we
forcibly closed the connection.
    @daveyarwood
    daveyarwood committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    52238bd View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. only call server.CloseConnection, and handle err if it returns one

    @daveyarwood
    daveyarwood committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f2074b6 View commit details
    Browse the repository at this point in the history

  2. assign the dispatcher to a separate variable to avoid making a type a… 

    …ssertion
    @daveyarwood
    daveyarwood committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7a03c8b View commit details
    Browse the repository at this point in the history

  3. fix "conversion from int to string yields a string of one rune" `go v… 

    …et` error

osc/osc_test.go:157:54: conversion from int to string yields a string of one rune

I found some context here: golang/go#32479
    @daveyarwood
    daveyarwood committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    8e375ff View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. osc_test: clean up / improve server connection closing behavior

    @daveyarwood
    daveyarwood committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    c892fea View commit details
    Browse the repository at this point in the history