Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine exactly which fields are and aren't required, and which are recommended #21

Open
thefinn93 opened this issue Nov 26, 2015 · 3 comments

Comments

@thefinn93
Copy link
Contributor

Currently test.py will fail if these fields are not present in any of the peering credentials:

  • publicKey
  • password
  • contact
    And throw warnings (which don't show up very easily, see Better warnings in tests #20) if these fields aren't present:
  • gpg
    Would people like to see these changed? I just kinda made these up while I was writing the tests script.

Other things to note:

  • Currently almost none of the peers listed have a GPG key (I believe EU/se/stockholm/leeloo.kyriasis.com.k is the only one)
  • The tests.py file has these fields defined in variables at the very top so it's trivial to change. Maybe eventually we'll even break it out into a proper config file.
@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 26, 2015

I think GPG should be optional, not everyone is using it but if it is present it would be nice if that fingerprint does not exist.

@kpcyrd
Copy link
Member

kpcyrd commented Nov 27, 2015

I think gpg should be optional. Anway, we need to agree on a format. With or without spaces between blocks? Full fingerprint or id?

@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 27, 2015

For sure full fingerprint (for short ones there were keys generated for each).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants