Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recommended fields #84

Open
ansuz opened this issue Oct 25, 2016 · 4 comments
Open

update recommended fields #84

ansuz opened this issue Oct 25, 2016 · 4 comments

Comments

@ansuz
Copy link
Member

ansuz commented Oct 25, 2016

should include "login" and "user".

"peerName" is apparently not super important.

@wfleurant
Copy link
Member

user is for server-side only -- used to identify user with a password, configurator.c seems optional
login is matched against user .. adds another barrier of cracking (notes way below)
peerName is useful not required, but may be we can keep it required to keep peerStats populated?

So it's still an optional field, we'd need 9 of 35 nodes to update / commit their connection before tests pass.

./af/ng/lagos/akinbo.lagos.ng.k
./na/us/massachusetts/igel-massachusetts.usa.k
./na/us/newjersey/newark/h.transitiontech.ca.k
./na/us/california/igel-california.usa.k
./na/us/pennsylvania/nat.usa.k
./eu/nl/amsterdam/igel-amersfoort.ams.k
./eu/nl/amsterdam/weuxel.ams.k
./eu/nl/amsterdam/mrowr.me.k
./eu/fr/strasbourg/magik6k.net.k
If a "login" parameter is passed, someone sniffing on the wire can
sniff the packet and crack to find it. If the "login" is not passed
then the hash of the 'password' is effectively the login, therefore
that can be cracked.

@kpcyrd
Copy link
Member

kpcyrd commented Jan 25, 2018

I think login is optional due to backwards compatibility (if I recall recorrectly).

Also, peerName used to be optional, I made it required in #118 to ensure sane peerStats output.

@ansuz
Copy link
Member Author

ansuz commented Jan 26, 2018

+1 for whatever y'all think is best.

@wfleurant
Copy link
Member

re: keep'em as required fields in test.py is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants