forked from zenon-network/syrius
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata escaping #8
Merged
KingGorrin
merged 17 commits into
hypercore-one:develop
from
KingGorrin:fix-metadata-escaping
May 17, 2023
Merged
Fix metadata escaping #8
KingGorrin
merged 17 commits into
hypercore-one:develop
from
KingGorrin:fix-metadata-escaping
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The build fails when merging a branch.
Why?
The build fails when one of the git variables contains special or escape characters like single quotes or \t.
The variables in the
metadata.dart
file are generated by scripts during the build. Having special characters in the git variables results in an incorrect variable declaration.Single quotes are used by gitHub when merging a branch, which will generate the following incorrect variable declartion.
How?
By using raw strings, the escape characters are not interpreted and only single quotes need to be replaced with
'"'"r'
.