Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ledger wallet support #8

Merged
merged 67 commits into from
Dec 13, 2023
Merged

Add Ledger wallet support #8

merged 67 commits into from
Dec 13, 2023

Conversation

KingGorrin
Copy link
Collaborator

@KingGorrin KingGorrin commented Dec 13, 2023

This PR adds support for the following:

Limitations

  • The following commands are not supported on Ledger wallets: wallet.createNew, wallet.createFromMnemonic, wallet.dumpMnemonic, wallet.export.

Tests

  • Added manual test runs

Known issues

  • A Ledger connection becomes invalid when another process opens a new connection to the Ledger. The invalid connection still responds to Ledger commands. The LedgerTransport throws a ResponseError when it detects invalid responses, but sometimes the response is valid but contains old data from memory. This can cause a Ledger command to return but with old data. The Ledger device is never actually called and in case of a signTx command no confirmation is asked. This issue will eventually cause an exception (for example when signing a transaction) and can only happen when creating multiple connections to the ledger.

@KingGorrin KingGorrin merged commit 4f79bc9 into main Dec 13, 2023
@KingGorrin KingGorrin deleted the bigint-ledger branch December 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant