Switch daemon to manual start rather than automatic #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for taking the time to address this. |
|
LGTM. Will merge this and release it with a new major bump -- this behavior does feel more correct |
|
Published in 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some folks integrating Hyper into Nix were having trouble with the CLI's automatic daemon init and requested we change to manual daemon start only. @mafintosh and I saw now problem with this, though it will need to be a major version bump.
For general errors, hyp exits with code 1. For daemon-not-active, it exits with code 2. That may be useful for anybody orchestrating the daemon to know.