style: rename 'buildAlertMessageTemplateBody'

packages/api/src/tasks/checkAlerts.ts

@@ -170,16 +170,6 @@ const notifyChannel = async ({
       throw new Error(`Unsupported channel type: ${channel}`);
   }
 };
-const renderAlertTemplate = (
-  template: string,
-  view: AlertMessageTemplateDefaultView,
-) => {
-  // Init the template engine
-  // need to seprate environments
-  const handlebars = Handlebars.create();
-  const compiledTemplate = handlebars.compile(template);
-  return compiledTemplate(view);
-};
 export const buildAlertMessageTemplateHdxLink = ({
   alert,
   dashboard,
@@ -224,22 +214,22 @@ export const buildAlertMessageTemplateTitle = ({
   view: AlertMessageTemplateDefaultView;
 }) => {
   const { alert, dashboard, savedSearch, value } = view;
+  const handlebars = Handlebars.create();
   if (alert.source === 'search') {
     if (savedSearch == null) {
       throw new Error('Source is LOG but logView is null');
     }
-
     // TODO: using template engine to render the title
     return template
-      ? renderAlertTemplate(template, view)
+      ? handlebars.compile(template)(view)
       : `Alert for "${savedSearch.name}" - ${value} lines found`;
   } else if (alert.source === 'chart') {
     if (dashboard == null) {
       throw new Error('Source is CHART but dashboard is null');
     }
     const chart = dashboard.charts[0];
     return template
-      ? renderAlertTemplate(template, view)
+      ? handlebars.compile(template)(view)
       : `Alert for "${chart.name}" in "${dashboard.name}" - ${value} ${
           doesExceedThreshold(
             alert.threshold_type === 'above',
@@ -276,7 +266,7 @@ export const translateExternalActionsToInternal = (template: string) => {
 };
 
 // this method will build the body of the alert message and will be used to send the alert to the channel
-export const buildAlertMessageTemplateBody = async ({
+export const renderAlertTemplate = async ({
   template,
   title,
   view,
@@ -299,7 +289,7 @@ export const buildAlertMessageTemplateBody = async ({
   const defaultExternalAction = getDefaultExternalAction(alert);
   const targetTemplate =
     defaultExternalAction !== null
-      ? // if the default external action is used, we won't use the actions from the template
+      ? // if the default external action is used, actions in the template won't be used
         `${template ?? ''} ${translateExternalActionsToInternal(
           defaultExternalAction,
         )}`
@@ -462,7 +452,7 @@ const fireChannelEvent = async ({
     value: totalCount,
   };
 
-  await buildAlertMessageTemplateBody({
+  await renderAlertTemplate({
     title: buildAlertMessageTemplateTitle({
       template: alert.name,
       view: templateView,