chore(deps): bump passport from 0.5.3 to 0.6.0 (#305)

Bumps [passport](https://github.com/jaredhanson/passport) from 0.5.3 to 0.6.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/jaredhanson/passport/blob/master/CHANGELOG.md">passport's changelog</a>.</em></p>
<blockquote>
<h2>[0.6.0] - 2022-05-20</h2>
<h3>Added</h3>
<ul>
<li><code>authenticate()</code>, <code>req#login</code>, and <code>req#logout</code> accept a
<code>keepSessionInfo: true</code> option to keep session information after regenerating
the session.</li>
</ul>
<h3>Changed</h3>
<ul>
<li><code>req#login()</code> and <code>req#logout()</code> regenerate the the session and clear session
information by default.</li>
<li><code>req#logout()</code> is now an asynchronous function and requires a callback
function as the last argument.</li>
</ul>
<h3>Security</h3>
<ul>
<li>Improved robustness against session fixation attacks in cases where there is
physical access to the same system or the application is susceptible to
cross-site scripting (XSS).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/jaredhanson/passport/commit/c33067bc5aa81a6dd827076d810bf788bb6acac7"><code>c33067b</code></a> 0.6.0</li>
<li><a href="https://github.com/jaredhanson/passport/commit/3052bb4717673b88a27981f6bc91a1f585889e5c"><code>3052bb4</code></a> Update changelog.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/42630cbd1ffd44d146ff96f0a4be6f3c12f81d75"><code>42630cb</code></a> Merge pull request <a href="https://redirect.github.com/jaredhanson/passport/issues/900">#900</a> from jaredhanson/fix-fixation</li>
<li><a href="https://github.com/jaredhanson/passport/commit/8dd79fe5f3f414435c4e0561fc925fb7ab6c8efb"><code>8dd79fe</code></a> Use utils-merge rather than Object.assign for compatibility.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/4f6bd5b254454d3f61c3236e8f1dd33472704fd3"><code>4f6bd5b</code></a> Change keepSessionData to keepSessionData.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/46756e56db671a822490f3d6c103a33a6691047d"><code>46756e5</code></a> Silence verbose logging.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/987b1918a2c5056531bbd325a2ff888a3595b2df"><code>987b191</code></a> Add tests.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/f8a175f1145c4efdffa7e4c511a642f608e11c0f"><code>f8a175f</code></a> Add tests.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/29a90d68dd5d4bc807bc658cfe49fba968b34d7d"><code>29a90d6</code></a> No need to guard callback existence.</li>
<li><a href="https://github.com/jaredhanson/passport/commit/bfba8a1ab44b658f745e33e3484b389f0751cdc0"><code>bfba8a1</code></a> Add tests.</li>
<li>Additional commits viewable in <a href="https://github.com/jaredhanson/passport/compare/v0.5.3...v0.6.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=passport&package-manager=npm_and_yarn&previous-version=0.5.3&new-version=0.6.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/hyperdxio/hyperdx/network/alerts).

</details>

Co-authored-by: Warren <5959690+wrn14897@users.noreply.github.com>

packages/api/package.json

@@ -36,7 +36,7 @@
     "node-schedule": "^2.1.1",
     "object-hash": "^3.0.0",
     "on-headers": "^1.0.2",
-    "passport": "^0.5.3",
+    "passport": "^0.6.0",
     "passport-local": "^1.0.0",
     "passport-local-mongoose": "^6.1.0",
     "pluralize": "^8.0.0",

packages/api/src/routers/api/root.ts

@@ -109,10 +109,13 @@ router.post(
   },
 );
 
-router.get('/logout', (req, res) => {
-  // @ts-ignore
-  req.logout();
-  res.redirect(`${config.FRONTEND_URL}/login`);
+router.get('/logout', (req, res, next) => {
+  req.logout(function (err) {
+    if (err) {
+      return next(err);
+    }
+    res.redirect(`${config.FRONTEND_URL}/login`);
+  });
 });
 
 // TODO: rename this ?

yarn.lock

@@ -11568,13 +11568,14 @@ passport-strategy@1.x.x:
   resolved "https://registry.yarnpkg.com/passport-strategy/-/passport-strategy-1.0.0.tgz#b5539aa8fc225a3d1ad179476ddf236b440f52e4"
   integrity sha512-CB97UUvDKJde2V0KDWWB3lyf6PC3FaZP7YxZ2G8OAtn9p4HI9j9JLP9qjOGZFvyl8uwNT8qM+hGnz/n16NI7oA==
 
-passport@^0.5.3:
-  version "0.5.3"
-  resolved "https://registry.yarnpkg.com/passport/-/passport-0.5.3.tgz#e69b46c9bb3290660bc2b3299330d78710b198cc"
-  integrity sha512-gGc+70h4gGdBWNsR3FuV3byLDY6KBTJAIExGFXTpQaYfbbcHCBlRRKx7RBQSpqEqc5Hh2qVzRs7ssvSfOpkUEA==
+passport@^0.6.0:
+  version "0.6.0"
+  resolved "https://registry.yarnpkg.com/passport/-/passport-0.6.0.tgz#e869579fab465b5c0b291e841e6cc95c005fac9d"
+  integrity sha512-0fe+p3ZnrWRW74fe8+SvCyf4a3Pb2/h7gFkQ8yTJpAO50gDzlfjZUZTO1k5Eg9kUct22OxHLqDZoKUWRHOh9ug==
   dependencies:
     passport-strategy "1.x.x"
     pause "0.0.1"
+    utils-merge "^1.0.1"
 
 path-exists@^4.0.0:
   version "4.0.0"
@@ -14387,7 +14388,7 @@ util-deprecate@^1.0.1:
   resolved "https://registry.yarnpkg.com/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"
   integrity sha512-EPD5q1uXyFxJpCrLnCc1nHnq3gOa6DZBocAIiI2TaSCA7VCJ1UJDMagCzIkXNsUYfD1daK//LTEQ8xiIbrHtcw==
 
-utils-merge@1.0.1:
+utils-merge@1.0.1, utils-merge@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/utils-merge/-/utils-merge-1.0.1.tgz#9f95710f50a267947b2ccc124741c1028427e713"
   integrity sha512-pMZTvIkT1d+TFGvDOqodOclx0QWkkgi6Tdoa8gC8ffGAAqz9pzPTZWAybbsHHoED/ztMtkv/VoYTYyShUn81hA==