Address comments

hyperdxio · Nov 4, 2023 · f9c657d · f9c657d
1 parent 6286878
commit f9c657d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/packages/app/src/LogSidePanel.tsx b/packages/app/src/LogSidePanel.tsx
@@ -495,8 +495,8 @@ function TraceSubpanel({
   }) => string;
 
   onPropertyAddClick?: (name: string, value: string) => void;
-  displayedColumns: string[];
-  toggleColumn: (column: string) => void;
+  displayedColumns?: string[];
+  toggleColumn?: (column: string) => void;
 }) {
   const date = new Date(logData.timestamp);
   const start = add(date, { minutes: -240 });
@@ -1666,11 +1666,11 @@ function PropertySubpanel({
                     className="fs-8 text-muted-hover child-hover-trigger p-0"
                     variant="link"
                     as="a"
-                    title={`${
+                    title={
                       displayedColumns?.includes(keyPathString)
-                        ? 'Remove'
-                        : 'Add'
-                    } ${keyPathString} column`}
+                        ? `Remove ${keyPathString} column from results table`
+                        : `Add ${keyPathString} column to results table`
+                    }
                     style={{ width: 20 }}
                     onClick={() => toggleColumn(keyPathString)}
                   >
@@ -2080,8 +2080,8 @@ export default function LogSidePanel({
   }) => string;
   sortKey: string | undefined;
   isNestedPanel?: boolean;
-  displayedColumns: string[];
-  toggleColumn: (column: string) => void;
+  displayedColumns?: string[];
+  toggleColumn?: (column: string) => void;
 }) {
   const contextZIndex = useZIndex();
 

diff --git a/packages/app/src/LogTableWithSidePanel.tsx b/packages/app/src/LogTableWithSidePanel.tsx
@@ -4,7 +4,7 @@ import usePortal from 'react-useportal';
 import type { LogView } from './types';
 import LogSidePanel from './LogSidePanel';
 import LogTable from './LogTable';
-import { useDisplayedColumns } from './hooks/useDisplayedColumns';
+import { useDisplayedColumns } from './useDisplayedColumns';
 
 export function LogTableWithSidePanel({
   config,

diff --git a/packages/app/src/SearchPage.tsx b/packages/app/src/SearchPage.tsx
@@ -45,7 +45,7 @@ import SearchPageActionBar from './SearchPageActionBar';
 import { useTimeQuery } from './timeQuery';
 import { MemoPatternTableWithSidePanel } from './PatternTableWithSidePanel';
 import { ErrorBoundary } from 'react-error-boundary';
-import { useDisplayedColumns } from './hooks/useDisplayedColumns';
+import { useDisplayedColumns } from './useDisplayedColumns';
 
 const formatDate = (
   date: Date,

diff --git a/...ages/app/src/hooks/useDisplayedColumns.ts → packages/app/src/useDisplayedColumns.ts b/...ages/app/src/hooks/useDisplayedColumns.ts → packages/app/src/useDisplayedColumns.ts