Implement CHART source alert (scheduled task) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 22b4432 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
changed the title
wrn14897
changed the title
wrn14897
commented
Nov 17, 2023
| }) => { | ||
| const searchQuery = alert.groupBy |
There was a problem hiding this comment.
move this to buildLogEventSlackMessage
wrn14897
commented
Nov 17, 2023
Comment on lines
+1403
to
+1404
| count(*) as data, | ||
| toUnixTimestamp(toStartOfInterval(timestamp, INTERVAL ?)) as ts_bucket |
There was a problem hiding this comment.
to be consistent with the output of getLogsChart. eventually this method will be replaced by it
wrn14897
commented
Nov 17, 2023
Comment on lines
104
to
114
| const mrkdwn = [ | ||
| `*<${buildChartLink({ | ||
| dashboardId: dashboard.id, | ||
| endTime, | ||
| granularity, | ||
| startTime, | ||
| })} | Alert for "${dashboard.chart.name}" in "${dashboard.name}">*`, | ||
| `${totalCount} lines found, expected ${ | ||
| alert.type === 'presence' ? 'less than' : 'greater than' | ||
| } ${alert.threshold} lines`, | ||
| ].join('\n'); |
There was a problem hiding this comment.
Lmk if we need to add more details to the alert UI
MikeShi42
reviewed
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.