Refine TableProps type definition using Record<string, unknown> #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced TableProps type precision with Record<string, unknown> - Preserved original structure with integrated improvements
|
wrn14897
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a refinement in type definitions within the TableProps.
What is the current behavior?
Previously, the TableProps used a less precise type definition.
What is the new behavior?
Now, TableProps uses Record<string, unknown> for a more accurate and robust type definition, enhancing the component's type safety.
Does this PR introduce a breaking change?
No breaking changes are introduced.
Other information:
The TableCellButton component remains unchanged as it was already optimally implemented.