Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix + ci: fix table type + setup unit test ci #130

Merged
merged 5 commits into from Nov 28, 2023
Merged

fix + ci: fix table type + setup unit test ci #130

merged 5 commits into from Nov 28, 2023

Conversation

wrn14897
Copy link
Contributor

@wrn14897 wrn14897 commented Nov 28, 2023 •
edited

  1. Added tsc type check to app lint cmd so it would capture type errors going forward (ex: regression from this PR 03f78dd)
  2. Run app unit tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023 •
edited

⚠️ No Changeset found

Latest commit: a12cc48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jaggederest
jaggederest approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jaggederest jaggederest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@kodiakhq kodiakhq bot merged commit e42b78f into main Nov 28, 2023
4 checks passed
@kodiakhq kodiakhq bot deleted the warren/fix-table-type-n-setup-frontend-ci branch November 28, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaggederest jaggederest jaggederest approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wrn14897 @jaggederest