Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: external api v1 route (get logs properties/chart + metrics tags/chart) + Mongo DB migration script #132

Merged
merged 9 commits into from
Nov 30, 2023
Merged

feat: external api v1 route (get logs properties/chart + metrics tags/chart) + Mongo DB migration script #132

merged 9 commits into from
Nov 30, 2023

Conversation

wrn14897
Copy link
Contributor

@wrn14897 wrn14897 commented Nov 30, 2023 •
edited
Loading

  1. Implement an additional API route to enable users to access data from the HyperDX API using a standard bearer token authentication method
  2. Setup Mongo DB migration tool

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 25593b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Minor
@hyperdx/app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wrn14897 wrn14897 changed the title feat: external api v1 route (get logs properties/chart + metrics tags/chart) feat: external api v1 route (get logs properties/chart + metrics tags/chart) + Mongo DB migration script Nov 30, 2023
MikeShi42
MikeShi42 previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a minor bump on changeset and probably a strong call out in the changelog that migrations need to be run if upgrading to this version for the API keys to work correctly on the external API

@wrn14897
Copy link
Contributor Author

need a minor bump on changeset and probably a strong call out in the changelog that migrations need to be run if upgrading to this version for the API keys to work correctly on the external API

Sounds good. I haven't finished the PR yet. Will add those to changeset

@kodiakhq kodiakhq bot merged commit 20b1f17 into main Nov 30, 2023
4 checks passed
@kodiakhq kodiakhq bot deleted the warren/add-external-api-route branch November 30, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaggederest jaggederest jaggederest approved these changes

@MikeShi42 MikeShi42 MikeShi42 left review comments

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wrn14897 @jaggederest @MikeShi42