feat: Enable metric alerts on dev #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
svc-shorpo
commented
Dec 5, 2023
svc-shorpo
commented
- Allow to set alerts for metric charts on development env
- Validation improvements for webhook alerts form (HDX-213)
🦋 Changeset detectedLatest commit: 74e11f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svc-shorpo
commented
Dec 5, 2023
| {/* Ensure user selects a slack webhook before submitting form */} | ||
| <option value="" disabled> | ||
| Select a Slack Webhook | ||
| <div className="mt-3"> |
There was a problem hiding this comment.
always showing this select to ensure required arg will prevent form from submitting. we can also improve UX and migrate to react-hook-forms later
svc-shorpo
force-pushed
the
sr/HDX-204
branch
from
1d7bc35
to
9520640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.