Minimal local mode #148
Minimal local mode #148
Conversation
|
docker/local/Dockerfile
Outdated
| RUN apk add --allow-untrusted otelcol-contrib_0.90.1_linux_arm64.apk | ||
|
|
||
| # == Install Node Deps == | ||
| RUN apk add nodejs npm yarn |
There was a problem hiding this comment.
better to use nvm use to lock node version
docker/local/Dockerfile
Outdated
|
|
||
| # == Install Vector Deps == | ||
| RUN apk add curl | ||
| RUN curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev | bash -s -- -y |
There was a problem hiding this comment.
we also want to specify vector version (
hyperdx/.github/workflows/main.yml
Line 28 in 843cfa3
docker/local/Dockerfile
Outdated
| RUN apk add mongodb yaml-cpp=0.6.2-r2 | ||
|
|
||
| # == Install Redis == | ||
| RUN apk add redis |
docker/local/build.sh
Outdated
| --build-context ingestor=./docker/ingestor \ | ||
| --build-context local=./docker/local \ | ||
| --build-context api=./packages/api \ | ||
| --build-context app=docker-image://ghcr.io/hyperdxio/hyperdx:1.3.0-app \ |
There was a problem hiding this comment.
Is this intentional ? (app context)
There was a problem hiding this comment.
Yes so we can avoid adding a builder step in the already tiring docker file 😅
There was a problem hiding this comment.
Makes sense. I think we probably want to read the version from .env (to pull the latest)
There was a problem hiding this comment.
that's true - now that i typed it out, i'll probably need to add the builder step here anyways in this dockerfile since we'll need to have a specific bundle for local mode for a few small changes. so for now this is really just a placeholder.
| @@ -27,6 +27,7 @@ | |||
| "jsonwebtoken": "^9.0.0", | |||
| "lodash": "^4.17.21", | |||
| "minimist": "^1.2.7", | |||
| "mongodb": "^6.3.0", | |||
There was a problem hiding this comment.
I think this is supposed to be dev dep ? (for migration script)
There was a problem hiding this comment.
It's actually a peer dep of connect-mongo, not sure why it was working before: https://github.com/jdesboeufs/connect-mongo/blob/master/package.json#L61
There was a problem hiding this comment.
from mongoose 🤷♂️ . also the peer seems to be ^4.1.0. anyway as long as it doesn't introduce deps issue
MikeShi42
force-pushed
the
mikeshi/local-mode-v0
branch
from
c7fdbd2
to
99a144a
Compare
MikeShi42
force-pushed
the
mikeshi/local-mode-v0
branch
from
99a144a
to
e48aaa7
Compare
|
|
||
| # == Clickhouse/Base Image == | ||
|
|
||
| FROM clickhouse/clickhouse-server:23.11.1-alpine AS clickhouse_base |
There was a problem hiding this comment.
I would suggest to align the ch version with the prebuilt and dev envs (v23.8.8)
|
|
||
| # == Install Vector Deps == | ||
| RUN apk add curl | ||
| RUN curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev | bash -s -- -y | ||
| RUN mkdir -p vector | ||
| RUN curl -sSfL --proto '=https' --tlsv1.2 https://packages.timber.io/vector/0.34.0/vector-0.34.0-x86_64-unknown-linux-musl.tar.gz | tar xzf - -C vector --strip-components=2 && \ |
Not ready for prime time yet, but does accomplish the basics of #7
A few things to iron out: