Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Overhaul Property JSON viewer #150

Merged
merged 4 commits into from
Dec 15, 2023
Merged

feat: Overhaul Property JSON viewer #150

merged 4 commits into from
Dec 15, 2023

Conversation

svc-shorpo
Copy link
Contributor

Screenshot 2023-12-10 at 10 14 46 PM

Screenshot 2023-12-10 at 10 14 36 PM

Screenshot 2023-12-10 at 10 14 33 PM

json.mov

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 465b2bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Minor
@hyperdx/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-shorpo
Copy link
Contributor Author

couple more things needs to be addressed

  1. wrap string values in pre
  2. don't allow text overflow

@svc-shorpo
Copy link
Contributor Author

couple more things needs to be addressed

addressed both, and also added an option to revert to previos json viewer

@svc-shorpo
Copy link
Contributor Author

also updated line menu actions to not take full height

Screenshot 2023-12-11 at 7 28 49 PM

Screenshot 2023-12-11 at 7 28 41 PM

MikeShi42
MikeShi42 previously approved these changes Dec 12, 2023
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff! only a minor feature deficit to the old viewer that I think is fine given there's still the fall back option available (it's a super niche use case)

onClick: handleCopyObject,
}
: {
key: 'copy-parent',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there's no way to actually ask to copy a parent any more in the flat view. On the old viewer this was accomplishable by clicking the key of the object, in the flat view.

Iiirc the use case was that users woud like to find a specific key/value via searching the flat view, and then copy the parent object for further use. I think we can alternatively allow users to search the nested view and copy objects there which might be cleaner.

@svc-shorpo svc-shorpo merged commit 60ee49a into main Dec 15, 2023
4 checks passed
@svc-shorpo svc-shorpo deleted the sr/json branch December 15, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants