feat: Alerts page styling #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
svc-shorpo
commented
Dec 30, 2023
•
svc-shorpo
commented
🦋 Changeset detectedLatest commit: c587e87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svc-shorpo
force-pushed
the
sr/alerts
branch
from
17721e2
to
c5b250f
Compare
svc-shorpo
commented
Dec 30, 2023
packages/app/src/AlertsPage.tsx
Outdated
| <Link href={`/dashboards/${alert.dashboard._id}`}> | ||
| <a className={styles.alertLink} title="Dashboard"> | ||
| <i className="bi bi-graph-up text-slate-400 me-2 fs-8" /> | ||
| {alert.dashboard.name} |
There was a problem hiding this comment.
would be nice to surface chart name here (in addition to dashboard.name)
There was a problem hiding this comment.
I think we have information to pull out the chart name, right ? (dashboard record + chartId)
svc-shorpo
force-pushed
the
sr/alerts
branch
from
c5b250f
to
65e9a4b
Compare
|
Screen.Recording.2023-12-31.at.12.44.55.AM.mov |
MikeShi42
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.