New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support count per sec/min/hr aggregation functions #198
Conversation
🦋 Changeset detectedLatest commit: 2d7ceec The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
? 'toFloat64(count()) as data' | ||
: aggFn === AggFn.CountPerSec | ||
? granularity | ||
? SqlString.format('divide(count(), ?) as data', [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for now, but I tend to think these kind of duplicates are safer as CountPer('second')
or equivalent. Maybe a TODO here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this select clause would probably need some refactoring later
No description provided.