Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Infra Pod Side Panel #215

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: Add Infra Pod Side Panel #215

merged 1 commit into from
Jan 10, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Jan 10, 2024 •
edited
Loading

Screenshot 2024-01-09 at 7 16 36 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 406699d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

svc-shorpo
svc-shorpo commented Jan 10, 2024
View reviewed changes
packages/app/src/PodDetailsSidePanel.tsx
</Box>
<Box className="w-100 overflow-auto" px="sm">
<Grid>
<Grid.Col span={6}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also add a header with pod status, created datetime, etc :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also lmk what other data we want to show here

@svc-shorpo svc-shorpo merged commit c2d35cb into main Jan 10, 2024
4 checks passed
@svc-shorpo svc-shorpo deleted the sr/pod-details branch January 10, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaggederest jaggederest jaggederest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svc-shorpo @jaggederest