Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Kubernetes dashboard boilerplate #242

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: Add Kubernetes dashboard boilerplate #242

merged 1 commit into from
Jan 18, 2024

Conversation

svc-shorpo
Copy link
Contributor

Screenshot 2024-01-16 at 10 53 52 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2024 •
edited

⚠️ No Changeset found

Latest commit: 8fb5d56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MikeShi42
MikeShi42 reviewed Jan 17, 2024
View reviewed changes
packages/app/src/config.ts
@@ -14,3 +14,4 @@ export const IS_OSS = process.env.NEXT_PUBLIC_IS_OSS ?? 'true' === 'true';
export const METRIC_ALERTS_ENABLED = process.env.NODE_ENV === 'development';
export const K8S_METRICS_ENABLED = process.env.NODE_ENV === 'development';
export const SERVICE_DASHBOARD_ENABLED = process.env.NODE_ENV === 'development';
export const K8S_DASHBOARD_ENABLED = process.env.NODE_ENV === 'development';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note for next time - we're starting to think of using specific env flags for specific features ex. NEXT_PUBLIC_DEV_K8S_DASHBOARD_ENABLED, this makes it easier to opt-in/out of UI on various environments like being able to do more dogfooding in staging without mucking NODE_ENV there.

Let's ship this as-is and this is an easy fix once we're closer to getting this in staging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@svc-shorpo svc-shorpo merged commit 5af48bb into main Jan 18, 2024
4 checks passed
@svc-shorpo svc-shorpo deleted the sr/kubernetes-dashboard branch January 18, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svc-shorpo @MikeShi42