Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): enable cursor in session player #33

Merged
merged 4 commits into from Sep 24, 2023

Conversation

mark-omarov
Copy link
Contributor

May close #31

The cursor was there, and it just had to be styled. I also disable it before the player starts, lmk if it looks good. Gif below :)

Kapture 2023-09-23 at 04 01 56

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: d9518fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks so much for taking a look and fixing it! If you can just rename the import we should be good to go :)

packages/app/src/DOMPlayer.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@MikeShi42 MikeShi42 merged commit 911c02a into hyperdxio:main Sep 24, 2023
2 checks passed
@mark-omarov mark-omarov deleted the feat/enable-replay-cursor branch September 24, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/emphasize cursor in session replay
2 participants