feat: Service Dashboard Errors Panel v0

[svc-shorpo]

---

	🚀 This PR description was created by Ellipsis for commit c25a80c.

Summary:

This PR adds a new 'Errors' tab in the Service Dashboard, displaying 'Error Events per Service' and 'Error Patterns', and makes the onShowEventsClick prop optional in PatternTableWithSidePanel.tsx.

Key points:

• Added a new 'Errors' tab in ServiceDashboardPage.tsx.
• The 'Errors' tab displays 'Error Events per Service' and 'Error Patterns'.
• 'Error Events per Service' uses the HDXMultiSeriesTimeChart component.
• 'Error Patterns' uses the MemoPatternTableWithSidePanel component.
• Made the onShowEventsClick prop optional in PatternTableWithSidePanel.tsx.

---

Generated with ❤️ by ellipsis.dev

[changeset-bot]

⚠️ No Changeset found

Latest commit: f2239bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ellipsis-dev]

❌ Changes requested.

• Reviewed the entire pull request up to 1d8457d
• Looked at 100 lines of code in 2 files
• Took 1 minute and 32 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_uwRXU9RXOgT0ZHJO

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

[ellipsis-dev]

The level filter in the scopeWhereQuery function should be 'level:"error"' instead of 'level:error' to correctly filter the logs.

Suggested change

	where: scopeWhereQuery('level:error'),
	where: scopeWhereQuery('level:"error"'),

[ellipsis-dev]

👍 Looks good to me!

• Performed an incremental review on f2239bc
• Looked at 99 lines of code in 2 files
• Took 20 minutes and 5 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 2 additional comments because they didn't meet confidence threshold of 50%.

1. /packages/app/src/ServiceDashboardPage.tsx:605:

• Assessed confidence : 50%
• Comment:
  The new 'Errors' tab in the Service Dashboard seems to be implemented correctly. The 'Error Events per Service' section uses the HDXMultiSeriesTimeChart component and the 'Error Patterns' section uses the MemoPatternTableWithSidePanel component. Please ensure that these components are used correctly and that the data passed to them is in the correct format.
• Reasoning:
  The PR introduces a new 'Errors' tab in the Service Dashboard, which includes two sections: 'Error Events per Service' and 'Error Patterns'. The 'Error Events per Service' section uses the HDXMultiSeriesTimeChart component to display a chart of error events per service. The 'Error Patterns' section uses the MemoPatternTableWithSidePanel component to display a table of error patterns. The onShowEventsClick prop in PatternTableWithSidePanel.tsx has been made optional. The code changes seem to be logically correct and follow best practices. There are no clear violations of best practices, logical bugs, performance bugs, or security bugs. However, I would like to check the HDXMultiSeriesTimeChart and MemoPatternTableWithSidePanel components to ensure they are used correctly.

2. /packages/app/src/PatternTableWithSidePanel.tsx:19:

• Assessed confidence : 50%
• Comment:
  The MemoPatternTableWithSidePanel component is used correctly in the 'Errors' tab to display a table of error patterns. Please ensure that the config prop passed to the component is in the correct format and includes all necessary properties.
• Reasoning:
  The MemoPatternTableWithSidePanel component is used to display a table of error patterns in the 'Errors' tab. The component takes a config prop which includes where and dateRange. The isUTC prop is used to determine whether the date and time should be displayed in UTC. The component uses several hooks to customize the table's appearance and behavior. The code seems to be logically correct and follows best practices. There are no clear violations of best practices, logical bugs, performance bugs, or security bugs.

Workflow ID: wflow_YluvfbYnPoriekjF

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.

[ellipsis-dev]

👍 Looks good to me!

• Performed an incremental review on c25a80c
• Looked at 99 lines of code in 2 files
• Took 2 minutes and 26 seconds to review

More info

• Skipped 0 files when reviewing.
• Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. /packages/app/src/PatternTableWithSidePanel.tsx:19:

• Assessed confidence : 50%
• Comment:
  The onShowEventsClick prop has been made optional. Please ensure that this does not cause issues in other parts of the codebase where this prop is expected to be mandatory.
• Reasoning:
  The PR introduces a new 'Errors' tab in the Service Dashboard, which displays 'Error Events per Service' and 'Error Patterns'. The changes seem to be in line with the PR description and there are no clear violations of best practices. However, I would like to point out that the onShowEventsClick prop in PatternTableWithSidePanel.tsx has been made optional. This could potentially lead to issues if there are places in the codebase where this prop is expected to be mandatory. I will need to explore the codebase to confirm this.

Workflow ID: wflow_yCPwucQBOl3v1wcT

---

Not what you expected? You can customize the content of the reviews using rules. Learn more here.