Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dashboard): Do not clip tooltips #349

Merged
merged 1 commit into from Apr 19, 2024
Merged

fix(Dashboard): Do not clip tooltips #349

merged 1 commit into from Apr 19, 2024

Conversation

svc-shorpo
Copy link
Contributor

Screen.Recording.2024-03-23.at.6.18.57.PM.mov

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2024 •
edited

⚠️ No Changeset found

Latest commit: 871e56c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MikeShi42
MikeShi42 approved these changes Mar 24, 2024
View reviewed changes
packages/app/src/DashboardPage.tsx
@@ -320,7 +320,7 @@ const Tile = forwardRef(
</div>
) : (
<div
className="fs-7 text-muted flex-grow-1 overflow-hidden"
className="fs-7 text-muted flex-grow-1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I can think of that we added this for is possibly for Y axis overflow (like a million legend items overflowing the tile). Though at this point I think we have legend overflow handling as well so should be safe to remove, unless we still need a overflow y hidden for some reason.

@kodiakhq kodiakhq bot merged commit 14ae58b into main Apr 19, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the sr/chart-tooltip-fix branch April 19, 2024 21:56
ernestii added a commit that referenced this pull request Apr 19, 2024
@ernestii
Revert "fix(Dashboard): Do not clip tooltips (#349)"
816500f 
This reverts commit 14ae58b.
kodiakhq bot pushed a commit that referenced this pull request Apr 19, 2024
@ernestii
Revert "fix(Dashboard): Do not clip tooltips (#349)" (#381)
1e7d7b4 
This reverts commit 14ae58b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svc-shorpo @MikeShi42 @ernestii