Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Saved Search Name #358

Merged
merged 6 commits into from Apr 5, 2024
Merged

Conversation

tzurae
Copy link
Contributor

@tzurae tzurae commented Mar 30, 2024

Currently, we are unable to change the name of a saved search. This PR primarily addresses this issue by adding a new option that appears when clicking the Menu icon in the top right corner. Upon selection, users will be able to enter a new name for the saved search. After pressing confirm, the change will be successfully applied.

Demo

chnage.saved.search.name.mp4

Copy link

changeset-bot bot commented Mar 30, 2024

⚠️ No Changeset found

Latest commit: f2c2474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/app/src/RenameSearchModal.tsx Outdated Show resolved Hide resolved
packages/app/src/SearchPage.tsx Outdated Show resolved Hide resolved
@tzurae tzurae requested a review from MikeShi42 March 31, 2024 15:29
MikeShi42
MikeShi42 previously approved these changes Mar 31, 2024
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - though a few changes I'd make to simplify it.

packages/app/src/SearchPage.tsx Outdated Show resolved Hide resolved
packages/app/src/SearchPage.tsx Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 63408cb into hyperdxio:main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants