Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds password show hide toggle switch #40

Closed
wants to merge 4 commits into from
Closed

feat: adds password show hide toggle switch #40

wants to merge 4 commits into from

Conversation

rtpa25
Copy link
Contributor

@rtpa25 rtpa25 commented Sep 23, 2023 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 34da74f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rtpa25
Copy link
Contributor Author

rtpa25 commented Sep 24, 2023

@wrn14897 @MikeShi42 let me know if you need any more UI improvements on this page

@mark-omarov mark-omarov mentioned this pull request Nov 7, 2023
Merged
@wrn14897
Copy link
Contributor

wrn14897 commented Nov 7, 2023

@wrn14897 @MikeShi42 let me know if you need any more UI improvements on this page

@rtpa25 Could you merge main and resolve the conflict ? I think we should be ready to merge this PR

wrn14897
wrn14897 reviewed Nov 7, 2023
View reviewed changes
packages/app/src/SVGIcons.tsx
@@ -248,3 +248,36 @@ export function S3Icon({ style, width }: IconProps) {
</svg>
);
}

export function Eye({ style, width }: IconProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use bootstrap icons instead https://icons.getbootstrap.com/?q=eye

@wrn14897
Copy link
Contributor

wrn14897 commented Jan 4, 2024

This is done

@wrn14897 wrn14897 closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrn14897 wrn14897 wrn14897 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX improvement on auth screen
2 participants
@rtpa25 @wrn14897