Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] support all annotations #1

Merged
merged 7 commits into from
Aug 19, 2021
Merged

[refactor] support all annotations #1

merged 7 commits into from
Aug 19, 2021

Conversation

weskiller
Copy link
Contributor

No description provided.

@huangzhhui
Copy link
Member

[This message is created by hyperf-bot]

Hi @weskiller, this is a READ-ONLY repository, please submit your Pull Request to hyperf/hyperf repository, this Pull Request will close automatically.

@huangzhhui huangzhhui closed this Aug 18, 2021
@limingxinleo
Copy link
Member

@weskiller 等等让 小哥 把 pr 打开

@huangzhhui huangzhhui reopened this Aug 19, 2021
@limingxinleo limingxinleo merged commit 2759fa6 into hyperf:main Aug 19, 2021
@limingxinleo
Copy link
Member

再提个 PR 把 README.md 也改改吧 @weskiller

@limingxinleo
Copy link
Member

@weskiller 我试了下。。Inject 有问题,你看单测,再改改代码把

@weskiller
Copy link
Contributor Author

weskiller commented Aug 19, 2021

@weskiller 我试了下。。Inject 有问题,你看单测,再改改代码把

单测有的示例有问题。

class Foo
{
    /**
     * @Inject
     * @var Bar
     */
    public $bar;
}
class Foo
{
    #[Inject]
    public Bar $bar;
}

不能直接将@var 转为属性的类型。

  • @var 可能声明的是一个不能转为类型的值,比如callable, int[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants