Optimize config

hyperf · Aug 22, 2023 · 046456f · 046456f
1 parent 162bc68
commit 046456f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/tracer/publish/opentracing.php b/src/tracer/publish/opentracing.php
@@ -43,7 +43,6 @@
                 'kafka' => [
                     'topic' => 'zipkin',
                     'bootstrap_servers' => '127.0.0.1:9092',
-                    'brokers' => null,
                     'acks' => -1,
                     'connect_timeout' => 1,
                     'send_timeout' => 1,

diff --git a/src/tracer/src/Adapter/Reporter/Kafka.php b/src/tracer/src/Adapter/Reporter/Kafka.php
@@ -68,21 +68,15 @@ public function report(array $spans): void
     private function createProducer(array $options): Producer
     {
         $options = array_replace([
-            'bootstrap_servers' => null,
-            'brokers' => null,
+            'bootstrap_servers' => '127.0.0.1:9092',
             'acks' => -1,
             'connect_timeout' => 1,
             'send_timeout' => 1,
         ], $options);
         $config = new ProducerConfig();
 
-        if (! empty($options['bootstrap_servers'])) {
-            $config->setBootstrapServer($options['bootstrap_servers']);
-            $config->setUpdateBrokers(true);
-        }
-        if (! empty($options['brokers'])) {
-            $config->setBrokers($options['brokers']);
-        }
+        $config->setBootstrapServer($options['bootstrap_servers']);
+        $config->setUpdateBrokers(true);
         if (is_int($options['acks'])) {
             $config->setAcks($options['acks']);
         }