Merge pull request #332 from qiqizjl/trace_bug

fix tracer middeware bug
hyperf · Aug 5, 2019 · 0f8d999 · 0f8d999
2 parents e356ca9 + b04348b
commit 0f8d999
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@
 ## Fixed
 
 - [#325](https://github.com/hyperf-cloud/hyperf/pull/325) Fixed consul service check the same service registration status more than one times.
+- [#332](https://github.com/hyperf-cloud/hyperf/pull/332) Fixed type error in `Hyperf\Tracer\Middleware\TraceMiddeware`.
 
 # v1.0.9 - 2019-08-03
 

diff --git a/src/tracer/publish/opentracing.php b/src/tracer/publish/opentracing.php
@@ -9,6 +9,7 @@
  * @contact  group@hyperf.io
  * @license  https://github.com/hyperf-cloud/hyperf/blob/master/LICENSE
  */
+
 use Zipkin\Samplers\BinarySampler;
 
 return [

diff --git a/src/tracer/src/Middleware/TraceMiddeware.php b/src/tracer/src/Middleware/TraceMiddeware.php
@@ -59,7 +59,7 @@ protected function buildSpan(ServerRequestInterface $request)
     {
         $uri = $request->getUri();
         $span = $this->tracing->span('request', SERVER);
-        $span->tag('coroutine.id', Coroutine::id());
+        $span->tag('coroutine.id', (string) Coroutine::id());
         $span->tag('request.path', (string) $uri);
         $span->tag('request.method', $request->getMethod());
         foreach ($request->getHeaders() as $key => $value) {