Skip to content

Commit

Permalink
Removed the redundant parameters of method `HasEvents::fireModelEvent…
Browse files Browse the repository at this point in the history
…()`. (#4905)

* Fixed typo in `file.php`

Co-authored-by: 李铭昕 <715557344@qq.com>
  • Loading branch information
her-cat and limingxinleo committed Jul 7, 2022
1 parent c5aef1f commit 5ed82f8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-3.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ composer analyse
- [#4875](https://github.com/hyperf/hyperf/pull/4875) Use the original style when regenerating models.
- [#4880](https://github.com/hyperf/hyperf/pull/4880) Support `ignoreAnnotations` for `Annotation Reader`.
- [#4888](https://github.com/hyperf/hyperf/pull/4888) Removed useless `Hyperf\Di\ClassLoader::$proxies`, because merge it into `Composer\Autoload\ClassLoader::$classMap`.
- [#4905](https://github.com/hyperf/hyperf/pull/4905) Removed the redundant parameters of method `Hyperf\Database\Model\Concerns\HasEvents::fireModelEvent()`.

## Changed

Expand Down
2 changes: 1 addition & 1 deletion src/database/src/Model/Concerns/HasRelationships.php
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ public function touchOwners()
$this->{$relation}()->touch();

if ($this->{$relation} instanceof self) {
$this->{$relation}->fireModelEvent('saved', false);
$this->{$relation}->fireModelEvent('saved');

$this->{$relation}->touchOwners();
} elseif ($this->{$relation} instanceof Collection) {
Expand Down
2 changes: 1 addition & 1 deletion src/database/src/Model/Model.php
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ public function newFromBuilder($attributes = [], $connection = null)

$model->setConnection($connection ?: $this->getConnectionName());

$model->fireModelEvent('retrieved', false);
$model->fireModelEvent('retrieved');

return $model;
}
Expand Down
2 changes: 1 addition & 1 deletion src/filesystem/publish/file.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
'accessKey' => env('QINIU_ACCESS_KEY'),
'secretKey' => env('QINIU_SECRET_KEY'),
'bucket' => env('QINIU_BUCKET'),
'domain' => env('QINBIU_DOMAIN'),
'domain' => env('QINIU_DOMAIN'),
],
'cos' => [
'driver' => \Hyperf\Filesystem\Adapter\CosAdapterFactory::class,
Expand Down

0 comments on commit 5ed82f8

Please sign in to comment.