Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grpc client Optimization #1273

Merged
merged 4 commits into from Jan 16, 2020
Merged

Grpc client Optimization #1273

merged 4 commits into from Jan 16, 2020

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Jan 13, 2020

gRPC-client optimization.

  1. gRPC client now automatically reconnects to the server after disconnection.

  2. when gRPC client is garbage collected, the connection is automatically closed.

  3. fix a bug where a closed gRPC client still holds the underlying http2 connection.

  4. fix a bug where channel pool for gRPC may contain non-empty channels.

  5. gRPC client now initializes itself lazily, so it can be used in constructor and container.

1. gRPC client now automatically reconnects to the server after disconnection.

2. when gRPC client is garbage collected, the connection is automatically closed.

3. fix a bug where a closed gRPC client still holds the underlying http2 connection.

4. fix a bug where channel pool for gRPC may contain non-empty channels.

5. gRPC client new initializes itself lazily, so it can be used in constructor and container.
@Reasno
Copy link
Member Author

Reasno commented Jan 14, 2020

本地测试中已经修复#1184#1225

@limingxinleo limingxinleo merged commit 0e26759 into hyperf:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants