Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted useless $httpMethod for Hyperf\RpcServer\Router\Router. #1303

Merged
merged 3 commits into from Jan 31, 2020
Merged

Deleted useless $httpMethod for Hyperf\RpcServer\Router\Router. #1303

merged 3 commits into from Jan 31, 2020

Conversation

imdake
Copy link
Contributor

@imdake imdake commented Jan 19, 2020 •
edited by limingxinleo

fix #1282

  1. 移除 rpc-server 的Router::addRoute第一参数 $httpMethod，因为RPC仅默认支持POST

@limingxinleo
Copy link
Member

limingxinleo commented Jan 19, 2020 •
edited

相关 PR #1285

@limingxinleo limingxinleo added the reviewing Reviewing a pull request label Jan 19, 2020
@limingxinleo limingxinleo changed the title 1. 移除 rpc-server 的Router::addRoute第一参数 $httpMethod，因为RPC仅默认支持POST Deleted useless $httpMethod for Hyperf\RpcServer\Router\Router. Jan 31, 2020
@limingxinleo limingxinleo merged commit cdc9aa5 into hyperf:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangzhhui huangzhhui huangzhhui approved these changes

Assignees
No one assigned
Labels
reviewing Reviewing a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] jsonrpc手动注册路由方法参数问题
3 participants
@imdake @limingxinleo @huangzhhui