Optimized error message when does not set the value of @var for @Inject. #2429

limingxinleo · 2020-09-03T09:50:56Z

limingxinleo · 2020-09-03T10:19:26Z

src/di/src/Annotation/Inject.php

@@ -74,6 +74,8 @@ public function collectProperty(string $className, ?string $target): void
                throw $exception;
            }
            $this->value = '';
+        } catch (\Throwable $exception) {
+            throw new AnnotationException("The @Inject value is invalid for {$className}->{$target}. Because {$exception->getMessage()}");


这里重置一下 Exception，不然错误信息看不到 @huangzhhui 你看一下，如果有啥不妥，我再改改。。

limingxinleo added 4 commits September 3, 2020 17:30

Update gen.md

521454a

Optimized error message when does not set the value of @var for @Inject.

660d895

Update doc

a93a795

Added test cases.

ba27567

limingxinleo commented Sep 3, 2020

View reviewed changes

limingxinleo merged commit cb66402 into hyperf:master Sep 3, 2020

limingxinleo deleted the 2.0-doc branch September 3, 2020 10:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimized error message when does not set the value of @var for @Inject. #2429

Optimized error message when does not set the value of @var for @Inject. #2429

limingxinleo commented Sep 3, 2020

limingxinleo Sep 3, 2020

Optimized error message when does not set the value of @var for @Inject. #2429

Optimized error message when does not set the value of @var for @Inject. #2429

Conversation

limingxinleo commented Sep 3, 2020

limingxinleo Sep 3, 2020

Choose a reason for hiding this comment