Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature rpc proxy factory #316

Closed
wants to merge 5 commits into from

Conversation

wenbinye
Copy link
Contributor

@wenbinye wenbinye commented Aug 1, 2019

rpc 调用支持自定义类型,支持业务异常支持,支持使用代理类调用

…turn type

DefinitionSource::add 方法原来只能添加 array 类型定义,没有看明白有什么意义。
修改成可添加其它声明相同的定义。
MethodDefinitionCollector 修改为实例方式,使用 kuiper/doc-reader 可从注解中
读取参数信息和返回值信息。
@limingxinleo
Copy link
Member

给你提个意见。。这个pr拆成多个比较好。。

@limingxinleo
Copy link
Member

#317

composer-json-updater 那个脚本,我移到这个 pr 里了。

@huangzhhui
Copy link
Member

拆成多个 PR 来提交吧,这样连 Changelog 都不好写了,一个 PR 只干一个事情

@huangzhhui huangzhhui closed this Aug 2, 2019
@wenbinye
Copy link
Contributor Author

wenbinye commented Aug 2, 2019

@limingxinleo 等会再合并吧,刚刚看测试不通过的原因是很多子项目里的 composer.json autoload-dev 没有写,我分开来提交 pr

@limingxinleo
Copy link
Member

@wenbinye 修 composer.json 那个我改了,你可以不用改那里。。

@wenbinye wenbinye deleted the feature-rpc-proxy-factory branch August 3, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants