Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the path argument of Mapping annotation is an empty string, then the path is equal to prefix of Controller annotation #501

Merged
merged 2 commits into from Sep 3, 2019
Merged

When the path argument of Mapping annotation is an empty string, then the path is equal to prefix of Controller annotation #501

merged 2 commits into from Sep 3, 2019

Conversation

huangzhhui
Copy link
Member

fix #488

@limingxinleo
Copy link
Member

limingxinleo commented Sep 2, 2019 •
edited

如果有用户认为 /api/users/ 是正确的，并且一直这么用的。。这么更新就会有问题了。。要不要在 changelog 里写一下可能出现的这种情况

如果出现这种情况，可以直接修改路由 为 /api/users/ 解决。

@huangzhhui
Copy link
Member Author

不是，现在你也没法通过注解的形式设置 /prefix/ 或者 /prefix 这样的路由，除了在 Mapping 上通过写全路由来设置，这里注解跟配置文件形式的 Group 的传值行为不一致

@limingxinleo limingxinleo self-requested a review September 3, 2019 01:35
limingxinleo
limingxinleo approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@limingxinleo limingxinleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那问题不大，合进来？

@huangzhhui huangzhhui merged commit cb296ae into 1.0 Sep 3, 2019
@huangzhhui huangzhhui deleted the huangzhhui-patch-1 branch September 4, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limingxinleo limingxinleo limingxinleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huangzhhui @limingxinleo