Simplify RunCommand's dependencies

.github/workflows/test.yml

@@ -18,7 +18,7 @@ jobs:
         exclude:
           - php-version: '8.2'
             sw-version: 'v4.8.12'
-      max-parallel: 12
+      max-parallel: 20
       fail-fast: false
     env:
       SW_VERSION: ${{ matrix.sw-version }}

CHANGELOG-3.0.md

@@ -11,6 +11,7 @@
 - [#5544](https://github.com/hyperf/hyperf/pull/5554) Cancel `grpc-server`'s dependency on `hyperf/rpc`.
 - [#5550](https://github.com/hyperf/hyperf/pull/5550) Optimized code for crontab parser and coordinator timer.
 - [#5566](https://github.com/hyperf/hyperf/pull/5566) Optimized the type hint to `nullable` for schemas which generated by `cmd`.
+- [#5569](https://github.com/hyperf/hyperf/pull/5569) Simplify RunCommand's dependencies.
 
 # v3.0.12 - 2023-03-20
 

src/crontab/src/Command/RunCommand.php

@@ -22,24 +22,18 @@
 
 class RunCommand extends Command
 {
-    protected Scheduler $scheduler;
-
-    protected Executor $executor;
-
-    protected ConfigInterface $config;
-
     public function __construct(protected ContainerInterface $container)
     {
         parent::__construct('crontab:run');
     }
 
     public function handle()
     {
-        $this->scheduler = $this->container->get(Scheduler::class);
-        $this->executor = $this->container->get(Executor::class);
-        $this->config = $this->container->get(ConfigInterface::class);
+        $config = $this->container->get(ConfigInterface::class);
+        $scheduler = $this->container->get(Scheduler::class);
+        $executor = $this->container->get(Executor::class);
 
-        if ($this->config->get('crontab.enable', false)) {
+        if ($config->get('crontab.enable', false)) {
             throw new InvalidArgumentException('Crontab is already disabled, please enable it first.');
         }
 
@@ -48,10 +42,12 @@ public function handle()
         $this->line('Triggering Crontab', 'info');
 
         /** @var Crontab[] $crontabs */
-        $crontabs = $this->scheduler->schedule();
+        $crontabs = $scheduler->schedule();
+
         foreach ($crontabs as $crontab) {
-            $this->executor->execute($crontab);
+            $executor->execute($crontab);
         }
+
         foreach ($crontabs as $crontab) {
             $crontab->wait();
         }