Optimized FailToConsume event for hyperf/kafka
#6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangdijia
changed the title
FailToConsume event of hyperf/kafka
huangdijia
changed the title
FailToConsume event of hyperf/kafkaFailToConsume event execution location of hyperf/kafka
limingxinleo
previously approved these changes
Sep 15, 2023
huangdijia
changed the title
FailToConsume event execution location of hyperf/kafkaFailToConsumeException for hyperf/kafka
huangdijia
changed the title
FailToConsumeException for hyperf/kafkaConsumeException for hyperf/kafka
huangdijia
changed the title
ConsumeException for hyperf/kafkaFailToConsume event for hyperf/kafka
|
这个放到 fix 里 |
assert6
previously approved these changes
Sep 15, 2023
This reverts commit e5f8a53.
limingxinleo
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6150
add FailConsume event that we can ack the message or report exception or others